Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Homepage Refresh #173

Open
wants to merge 30 commits into
base: main
Choose a base branch
from
Open

Homepage Refresh #173

wants to merge 30 commits into from

Conversation

bryantgillespie
Copy link
Member

@bryantgillespie bryantgillespie commented Nov 13, 2024 •
edited
Loading

Adding a new glow-up to the Directus homepage.

New Components

  • Carousel
  • Testimonial Wall Of Love
  • Masonry Grid

Updates to Old Components

  • Logo Cloud
  • Paper

@netlify Netlify
Copy link

netlify bot commented Nov 13, 2024 •
edited
Loading

❌ Deploy Preview for directus-website failed. Why did it fail? →

Name Link
🔨 Latest commit 12359b5
🔍 Latest deploy log https://app.netlify.com/sites/directus-website/deploys/6740ba73e8fbed0008a8d0c4

@LZylstra LZylstra marked this pull request as ready for review November 15, 2024 14:51
bryantgillespie
bryantgillespie commented Nov 19, 2024
View reviewed changes
components/Block/WallOfLove/Testimonials.vue Outdated Show resolved Hide resolved
components/Block/WallOfLove/Testimonials.vue Outdated Show resolved Hide resolved
components/Block/WallOfLove/Testimonials.vue Outdated Show resolved Hide resolved
components/Block/Carousel/CarouselCard.vue Outdated Show resolved Hide resolved
components/Block/Carousel/Carousel.vue Outdated Show resolved Hide resolved
components/Block/Carousel/CarouselCard.vue Outdated Show resolved Hide resolved
@bryantgillespie bryantgillespie marked this pull request as draft November 20, 2024 16:07
@bryantgillespie bryantgillespie marked this pull request as ready for review November 20, 2024 16:07
AlexGaillard
AlexGaillard requested changes Nov 21, 2024
View reviewed changes
Copy link
Member

@AlexGaillard AlexGaillard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes and questions here. Looks great otherwise 😄 👍

components/Base/Block.vue Outdated Show resolved Hide resolved
components/Carousel/CarouselItem.vue Outdated Show resolved Hide resolved
components/LogoDoubleTicker.vue Outdated Show resolved Hide resolved
components/LogoDoubleTicker.vue Outdated Show resolved Hide resolved
components/Carousel/CarouselContent.vue Outdated Show resolved Hide resolved
components/LogoDoubleTicker.vue Outdated Show resolved Hide resolved
types/schema/blocks/block.ts Outdated Show resolved Hide resolved
types/schema/schema.ts Outdated Show resolved Hide resolved
AlexGaillard
AlexGaillard reviewed Nov 22, 2024
View reviewed changes
components/Block/WallOfLove/WallOfLove.vue
Copy link
Member

@AlexGaillard AlexGaillard Nov 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Still getting these which will cause build error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexGaillard AlexGaillard AlexGaillard requested changes

@LZylstra LZylstra LZylstra left review comments

Requested changes must be addressed to merge this pull request.

Assignees

@LZylstra LZylstra

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bryantgillespie @LZylstra @AlexGaillard